fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-06 02:40:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform: downgrade severity of message for failure to create NMPNetns

Browse source 
Under restricted permissions (like inside a podman container) opening
"/proc/self/ns/net" fails with Permission denied. Consequently we cannot
create our bottom NMPNetns instance. That is mostly fine, however we
would log an error message with severity <error>.

Note that test "src/core/platform/tests/test-platform-general" asserts
that no <warn> and <error> messages get logged. Hence, the test will
fail.

That is undesirable. Downgrade the message to <debug> so that the test
passes. Also, it's not clear that this error message is useful here.
Being unable to open a netns fd is fine and not necessarily an error
condition.
This commit is contained in:
Thomas Haller 2021-02-15 20:52:55 +01:00
parent f9636080ac
commit 0213300dce
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shared/nm-platform/nmp-netns.c
View file

@ -171,7 +171,7 @@ _netns_stack_get_impl(void)
netns = _netns_new(&error);
if (!netns) {
_LOGE(NULL, "failed to create initial netns: %s", error->message);
_LOGD(NULL, "failed to create initial netns: %s", error->message);
return s;
}