From 018c5722ee63023ffe22123cc63754022dbf9968 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20M=C3=BCller?= Date: Thu, 9 Oct 2025 06:42:22 +0000 Subject: [PATCH] Fix the exit test condition on modem state when creating the connection properties --- NEWS | 3 +++ src/core/devices/wwan/nm-modem-broadband.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index db2282d655..ecfd4cf4ac 100644 --- a/NEWS +++ b/NEWS @@ -20,6 +20,9 @@ USE AT YOUR OWN RISK. NOT RECOMMENDED FOR PRODUCTION USE! * Add gsm device-uid setting to restrict the devices the connection applies to. * Support configuring the HSR protocol version via the "hsr.protocol-version" property. +* Fix a bug that makes broadband connections auto-connect getting + blocked if the connection tries to reconnect when modem status is + "disconnecting" / "disconnected". ============================================= NetworkManager-1.54 diff --git a/src/core/devices/wwan/nm-modem-broadband.c b/src/core/devices/wwan/nm-modem-broadband.c index cd03b83465..6fee5030b7 100644 --- a/src/core/devices/wwan/nm-modem-broadband.c +++ b/src/core/devices/wwan/nm-modem-broadband.c @@ -522,7 +522,7 @@ try_create_connect_properties(NMModemBroadband *self) if (s_gsm) network_id = nm_setting_gsm_get_network_id(s_gsm); if (!network_id) { - if (mm_modem_get_state(self->_priv.modem_iface) < MM_MODEM_STATE_REGISTERED) + if (mm_modem_get_state(self->_priv.modem_iface) != MM_MODEM_STATE_REGISTERED) return FALSE; modem_3gpp = mm_object_get_modem_3gpp(priv->modem_object); network_id = mm_modem_3gpp_get_operator_code(modem_3gpp);