fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-06-20 09:28:28 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

nmtui/wireguard: fix peer leak when adding new peer

Browse source 
nm_wireguard_peer_new() returns a new peer with refcount 1.
nmt_wireguard_peer_editor_new() takes its own copy via
g_value_dup_boxed(), so the original peer was never unreffed.

Unref the peer after passing it to the editor.

Found by Coverity (CID: RESOURCE_LEAK).

Fixes: b0f5b1d97a ('tui: add WireGuard support to nmtui')
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jan Vaclav 2026-04-07 12:42:32 +02:00
parent 8685ac1845
commit 00f9a3d862
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/nmtui/nmt-wireguard-peer-list.c
View file

@ -170,6 +170,7 @@ nmt_wireguard_peer_list_add_peer(NmtWireguardPeerList *list)
NmtNewtForm *editor;
editor = nmt_wireguard_peer_editor_new(priv->setting, peer);
nm_wireguard_peer_unref(peer);
if (!editor)
return;