From 003eb75eb63000747d2daca48038717e33c8fb9a Mon Sep 17 00:00:00 2001 From: Fernando Fernandez Mancera Date: Wed, 10 Aug 2022 21:50:15 +0200 Subject: [PATCH] bond: fix parsing of arp_ip_target to platform nm_setting_bond_get_option_normalized() is returning the arp_ip_target IPs separated by comma instead of a blank space. https://bugzilla.redhat.com/show_bug.cgi?id=2117202 Fixes: e064eb9d1361 ('bond: use netlink to set bond options') --- src/core/devices/nm-device-bond.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/devices/nm-device-bond.c b/src/core/devices/nm-device-bond.c index ef1baef788..41473abeca 100644 --- a/src/core/devices/nm-device-bond.c +++ b/src/core/devices/nm-device-bond.c @@ -360,7 +360,7 @@ _bond_arp_ip_target_to_platform(const char *value, in_addr_t out[static NM_BOND_ int i; int added = 0; - ip = nm_strsplit_set(value, " "); + ip = nm_utils_bond_option_arp_ip_targets_split(value); if (!ip) return added; @@ -369,7 +369,7 @@ _bond_arp_ip_target_to_platform(const char *value, in_addr_t out[static NM_BOND_ if (added > NM_BOND_MAX_ARP_TARGETS - 1) break; if (!nm_utils_parse_inaddr_bin(AF_INET, ip[i], NULL, &in_a)) - continue; + nm_assert_not_reached(); /* verify() already validated the IP addresses */ out[added++] = in_a; }