fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-03-07 04:00:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src/core/nm-pacrunner-manager.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

37 lines
1.4 KiB
C
Raw Normal View History

all: update deprecated SPDX license identifiers These SPDX license identifiers are deprecated ([1]). Update them. [1] https://spdx.org/licenses/ sed \ -e '1 s%^/\* SPDX-License-Identifier: \(GPL-2.0\|LGPL-2.1\)+ \*/$%/* SPDX-License-Identifier: \1-or-later */%' \ -e '1,2 s%^\(--\|#\|//\) SPDX-License-Identifier: \(GPL-2.0\|LGPL-2.1\)+$%\1 SPDX-License-Identifier: \2-or-later%' \ -i \ $(git grep -l SPDX-License-Identifier -- \ ':(exclude)shared/c-*/' \ ':(exclude)shared/n-*/' \ ':(exclude)shared/systemd/src' \ ':(exclude)src/systemd/src')
2020-12-23 22:21:36 +01:00
/* SPDX-License-Identifier: GPL-2.0-or-later */
all: manually drop code comments with file description
2019-09-25 13:13:40 +02:00
/*
all: unify format of our Copyright source code comments ```bash readarray -d '' FILES < <( git ls-files -z \ ':(exclude)po' \ ':(exclude)shared/c-rbtree' \ ':(exclude)shared/c-list' \ ':(exclude)shared/c-siphash' \ ':(exclude)shared/c-stdaux' \ ':(exclude)shared/n-acd' \ ':(exclude)shared/n-dhcp4' \ ':(exclude)src/systemd/src' \ ':(exclude)shared/systemd/src' \ ':(exclude)m4' \ ':(exclude)COPYING*' ) sed \ -e 's/^\(--\|#\| \*\) *\(([cC]) *\)\?Copyright \+\(\(([cC])\) \+\)\?\(\(20\|19\)[0-9][0-9]\) *[-–] *\(\(20\|19\)[0-9][0-9]\) \+\([^ ].*\)$/\1 C1pyright#\5 - \7#\9/' \ -e 's/^\(--\|#\| \*\) *\(([cC]) *\)\?Copyright \+\(\(([cC])\) \+\)\?\(\(20\|19\)[0-9][0-9]\) *[,] *\(\(20\|19\)[0-9][0-9]\) \+\([^ ].*\)$/\1 C2pyright#\5, \7#\9/' \ -e 's/^\(--\|#\| \*\) *\(([cC]) *\)\?Copyright \+\(\(([cC])\) \+\)\?\(\(20\|19\)[0-9][0-9]\) \+\([^ ].*\)$/\1 C3pyright#\5#\7/' \ -e 's/^Copyright \(\(20\|19\)[0-9][0-9]\) \+\([^ ].*\)$/C4pyright#\1#\3/' \ -i \ "${FILES[@]}" echo ">>> untouched Copyright lines" git grep Copyright "${FILES[@]}" echo ">>> Copyright lines with unusual extra" git grep '\<C[0-9]pyright#' "${FILES[@]}" | grep -i reserved sed \ -e 's/\<C[0-9]pyright#\([^#]*\)#\(.*\)$/Copyright (C) \1 \2/' \ -i \ "${FILES[@]}" ``` https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/298
2019-10-01 09:20:35 +02:00
* Copyright (C) 2016 Atul Anand <atulhjp@gmail.com>.
* Copyright (C) 2016 - 2017 Red Hat, Inc.
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
*/
#ifndef __NETWORKMANAGER_PACRUNNER_MANAGER_H__
#define __NETWORKMANAGER_PACRUNNER_MANAGER_H__
proxy: rename NMPacRunnerManager to NMPacrunnerManager The names NMPacRunnerManager, nm_pac_runner_manager were inconsistent with NM_PACRUNNER_MANAGER and nm-pacrunner-manager.[hc]. They should be consistent. It seems pacrunner project calls itself "PACrunner" or just "pacrunner", so prefer the spelling with lower-case 'r'.
2016-10-04 12:13:16 +02:00
#define NM_TYPE_PACRUNNER_MANAGER (nm_pacrunner_manager_get_type())
#define NM_PACRUNNER_MANAGER(obj) \
all: use _NM_G_TYPE_CHECK_INSTANCE_CAST() for internal uses G_TYPE_CHECK_INSTANCE_CAST() can trigger a "-Wcast-align": src/core/devices/nm-device-macvlan.c: In function 'parent_changed_notify': /usr/include/glib-2.0/gobject/gtype.h:2421:42: error: cast increases required alignment of target type [-Werror=cast-align] 2421 | # define _G_TYPE_CIC(ip, gt, ct) ((ct*) ip) | ^ /usr/include/glib-2.0/gobject/gtype.h:501:66: note: in expansion of macro '_G_TYPE_CIC' 501 | #define G_TYPE_CHECK_INSTANCE_CAST(instance, g_type, c_type) (_G_TYPE_CIC ((instance), (g_type), c_type)) | ^~~~~~~~~~~ src/core/devices/nm-device-macvlan.h:13:6: note: in expansion of macro 'G_TYPE_CHECK_INSTANCE_CAST' 13 | (G_TYPE_CHECK_INSTANCE_CAST((obj), NM_TYPE_DEVICE_MACVLAN, NMDeviceMacvlan)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Avoid that by using _NM_G_TYPE_CHECK_INSTANCE_CAST(). This can only be done for our internal usages. The public headers of libnm are not changed.
2022-12-14 16:21:48 +01:00
(_NM_G_TYPE_CHECK_INSTANCE_CAST((obj), NM_TYPE_PACRUNNER_MANAGER, NMPacrunnerManager))
proxy: rename NMPacRunnerManager to NMPacrunnerManager The names NMPacRunnerManager, nm_pac_runner_manager were inconsistent with NM_PACRUNNER_MANAGER and nm-pacrunner-manager.[hc]. They should be consistent. It seems pacrunner project calls itself "PACrunner" or just "pacrunner", so prefer the spelling with lower-case 'r'.
2016-10-04 12:13:16 +02:00
#define NM_PACRUNNER_MANAGER_CLASS(klass) \
(G_TYPE_CHECK_CLASS_CAST((klass), NM_TYPE_PACRUNNER_MANAGER, NMPacrunnerManagerClass))
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
#define NM_IS_PACRUNNER_MANAGER(obj) (G_TYPE_CHECK_INSTANCE_TYPE((obj), NM_TYPE_PACRUNNER_MANAGER))
#define NM_IS_PACRUNNER_MANAGER_CLASS(klass) \
(G_TYPE_CHECK_CLASS_TYPE((klass), NM_TYPE_PACRUNNER_MANAGER))
proxy: rename NMPacRunnerManager to NMPacrunnerManager The names NMPacRunnerManager, nm_pac_runner_manager were inconsistent with NM_PACRUNNER_MANAGER and nm-pacrunner-manager.[hc]. They should be consistent. It seems pacrunner project calls itself "PACrunner" or just "pacrunner", so prefer the spelling with lower-case 'r'.
2016-10-04 12:13:16 +02:00
#define NM_PACRUNNER_MANAGER_GET_CLASS(obj) \
(G_TYPE_INSTANCE_GET_CLASS((obj), NM_TYPE_PACRUNNER_MANAGER, NMPacrunnerManagerClass))
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
proxy: rename NMPacRunnerManager to NMPacrunnerManager The names NMPacRunnerManager, nm_pac_runner_manager were inconsistent with NM_PACRUNNER_MANAGER and nm-pacrunner-manager.[hc]. They should be consistent. It seems pacrunner project calls itself "PACrunner" or just "pacrunner", so prefer the spelling with lower-case 'r'.
2016-10-04 12:13:16 +02:00
typedef struct _NMPacrunnerManagerClass NMPacrunnerManagerClass;
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
pacrunner: refactor pacrunner to use GDBusConnection - use GDBusConnection instead of GDBusProxy. - rename "call-id" to "conf-id". It's really not a "call" but configuration that gets added and NMPacrunnerManager ensures that the configuration is send to pacrunner. - let "conf-id" keep a reference to NMPacrunnerManager. For one, when we remove configurations we need to call DestroyProxyConfiguration to remove it again. We cannot just abort the requests but must linger around until our configuration is properly cleaned up. Hence, we anyway cannot destroy the NMPacrunnerManager earlier. With respect to fixing shutdown not to leak anything, this merely means that we must wait (and iterate the main loop) as long as NMPacrunnerManager singleton still exits (that is anyway the plan how to fix shutdown). With these considerations it's also clear that our D-Bus calls must have a stricter timeout: NM_SHUTDOWN_TIMEOUT_MS. This is also nice because nm_pacrunner_manager_remove() no longer needs a manager parameter, it can just rely on having a reference to the manager. - for logging the configuration IDs, don't log pointer values. Logging pointer values should be avoided as it defeats ASLR. Instead, give them a "log_id" number. - pacrunner is a D-Bus activatable service. D-Bus activatable services needs special care. We don't want to start it over and over again. Instead, we only try to "StartServiceByName" if - we have any configuration to add - if pacrunner is currently confirmed not to be running (by watching name owner changes) - we didn't try to start it already. That means, only start it at the beginning and afterwards set a flag to block it. When we see pacrunner appear on D-Bus we always clear that flag, that means if pacrunner drops of, we will try to restart it (once).
2019-05-05 09:51:09 +02:00
typedef struct _NMPacrunnerConfId NMPacrunnerConfId;
proxy: introduce call-id for clearing pacmanager configuration nm_pacrunner_manager_remove() required a "tag" argument. It was a bug for callers trying to remove a configuration for a non-existing tag. That effectively means, the caller must keep track of whether a certain "tag" is pending. The caller also must remember the tag -- a tag that he must choose uniquely in the first place. Turn that around and have nm_pacrunner_manager_send() return a (non NULL) call-id. This call-id may later be used to remove the configuration. Apparently, previously the tracking of the "tag" was not always correct and we hit the assertion in nm_pacrunner_manager_remove(). https://bugzilla.redhat.com/show_bug.cgi?id=1444374 (cherry picked from commit b04a9c90eb0a866f2d730cc4777b4f670220ddc7)
2017-04-21 15:46:56 +02:00
proxy: rename NMPacRunnerManager to NMPacrunnerManager The names NMPacRunnerManager, nm_pac_runner_manager were inconsistent with NM_PACRUNNER_MANAGER and nm-pacrunner-manager.[hc]. They should be consistent. It seems pacrunner project calls itself "PACrunner" or just "pacrunner", so prefer the spelling with lower-case 'r'.
2016-10-04 12:13:16 +02:00
GType nm_pacrunner_manager_get_type(void);
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
proxy: rename NMPacRunnerManager to NMPacrunnerManager The names NMPacRunnerManager, nm_pac_runner_manager were inconsistent with NM_PACRUNNER_MANAGER and nm-pacrunner-manager.[hc]. They should be consistent. It seems pacrunner project calls itself "PACrunner" or just "pacrunner", so prefer the spelling with lower-case 'r'.
2016-10-04 12:13:16 +02:00
NMPacrunnerManager *nm_pacrunner_manager_get(void);
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
core: rework IP configuration in NetworkManager using layer 3 configuration Completely rework IP configuration in the daemon. Use NML3Cfg as layer 3 manager for the IP configuration of an interface. Use NML3ConfigData as pieces of configuration that the various components collect and configure. NMDevice is managing most of the IP configuration at a higher level, that is, it starts DHCP and other IP methods. Rework the state handling there. This is a huge rework of how NetworkManager daemon handles IP configuration. Some fallout is to be expected. It appears the patch deletes many lines of code. That is not accurate, because you also have to count the files `src/core/nm-l3*`, which were unused previously. Co-authored-by: Beniamino Galvani <bgalvani@redhat.com>
2021-08-06 15:17:05 +02:00
NMPacrunnerConfId *
nm_pacrunner_manager_add(NMPacrunnerManager *self, const char *iface, const NML3ConfigData *l3cd);
proxy: introduce call-id for clearing pacmanager configuration nm_pacrunner_manager_remove() required a "tag" argument. It was a bug for callers trying to remove a configuration for a non-existing tag. That effectively means, the caller must keep track of whether a certain "tag" is pending. The caller also must remember the tag -- a tag that he must choose uniquely in the first place. Turn that around and have nm_pacrunner_manager_send() return a (non NULL) call-id. This call-id may later be used to remove the configuration. Apparently, previously the tracking of the "tag" was not always correct and we hit the assertion in nm_pacrunner_manager_remove(). https://bugzilla.redhat.com/show_bug.cgi?id=1444374 (cherry picked from commit b04a9c90eb0a866f2d730cc4777b4f670220ddc7)
2017-04-21 15:46:56 +02:00
pacrunner: refactor pacrunner to use GDBusConnection - use GDBusConnection instead of GDBusProxy. - rename "call-id" to "conf-id". It's really not a "call" but configuration that gets added and NMPacrunnerManager ensures that the configuration is send to pacrunner. - let "conf-id" keep a reference to NMPacrunnerManager. For one, when we remove configurations we need to call DestroyProxyConfiguration to remove it again. We cannot just abort the requests but must linger around until our configuration is properly cleaned up. Hence, we anyway cannot destroy the NMPacrunnerManager earlier. With respect to fixing shutdown not to leak anything, this merely means that we must wait (and iterate the main loop) as long as NMPacrunnerManager singleton still exits (that is anyway the plan how to fix shutdown). With these considerations it's also clear that our D-Bus calls must have a stricter timeout: NM_SHUTDOWN_TIMEOUT_MS. This is also nice because nm_pacrunner_manager_remove() no longer needs a manager parameter, it can just rely on having a reference to the manager. - for logging the configuration IDs, don't log pointer values. Logging pointer values should be avoided as it defeats ASLR. Instead, give them a "log_id" number. - pacrunner is a D-Bus activatable service. D-Bus activatable services needs special care. We don't want to start it over and over again. Instead, we only try to "StartServiceByName" if - we have any configuration to add - if pacrunner is currently confirmed not to be running (by watching name owner changes) - we didn't try to start it already. That means, only start it at the beginning and afterwards set a flag to block it. When we see pacrunner appear on D-Bus we always clear that flag, that means if pacrunner drops of, we will try to restart it (once).
2019-05-05 09:51:09 +02:00
void nm_pacrunner_manager_remove(NMPacrunnerConfId *conf_id);
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
pacrunner: refactor pacrunner to use GDBusConnection - use GDBusConnection instead of GDBusProxy. - rename "call-id" to "conf-id". It's really not a "call" but configuration that gets added and NMPacrunnerManager ensures that the configuration is send to pacrunner. - let "conf-id" keep a reference to NMPacrunnerManager. For one, when we remove configurations we need to call DestroyProxyConfiguration to remove it again. We cannot just abort the requests but must linger around until our configuration is properly cleaned up. Hence, we anyway cannot destroy the NMPacrunnerManager earlier. With respect to fixing shutdown not to leak anything, this merely means that we must wait (and iterate the main loop) as long as NMPacrunnerManager singleton still exits (that is anyway the plan how to fix shutdown). With these considerations it's also clear that our D-Bus calls must have a stricter timeout: NM_SHUTDOWN_TIMEOUT_MS. This is also nice because nm_pacrunner_manager_remove() no longer needs a manager parameter, it can just rely on having a reference to the manager. - for logging the configuration IDs, don't log pointer values. Logging pointer values should be avoided as it defeats ASLR. Instead, give them a "log_id" number. - pacrunner is a D-Bus activatable service. D-Bus activatable services needs special care. We don't want to start it over and over again. Instead, we only try to "StartServiceByName" if - we have any configuration to add - if pacrunner is currently confirmed not to be running (by watching name owner changes) - we didn't try to start it already. That means, only start it at the beginning and afterwards set a flag to block it. When we see pacrunner appear on D-Bus we always clear that flag, that means if pacrunner drops of, we will try to restart it (once).
2019-05-05 09:51:09 +02:00
gboolean nm_pacrunner_manager_remove_clear(NMPacrunnerConfId **p_conf_id);
src:(pacrunner-manager): Object for interaction with PacRunner A new object NMPacRunnerManager has been added to manage and interact PacRunner. It invokes both DBus methods on PacRunner DBus interface. It stores the returned object path from CreateProxyConfiguration() to feed as parameter to DestroyProxyCofiguration() when network goes down.
2016-08-16 05:55:57 +05:30
#endif /* __NETWORKMANAGER_PACRUNNER_MANAGER_H__ */
Reference in a new issue Copy permalink