NetworkManager/src/rdisc/tests/test-rdisc-linux.c

76 lines
1.8 KiB
C
Raw Normal View History

/* -*- Mode: C; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */
/* rdisc.c - test program
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Copyright (C) 2013 Red Hat, Inc.
*/
#include "config.h"
2013-05-31 15:49:07 +02:00
#include <string.h>
#include <syslog.h>
#include "nm-rdisc.h"
2013-05-31 15:49:07 +02:00
#include "nm-lndp-rdisc.h"
#include "nm-logging.h"
#include "nm-linux-platform.h"
#include "nm-test-utils.h"
NMTST_DEFINE ();
int
main (int argc, char **argv)
{
GMainLoop *loop;
NMRDisc *rdisc;
2013-05-31 15:49:07 +02:00
int ifindex = 1;
const char *ifname;
2013-05-31 15:49:07 +02:00
nmtst_init_with_logging (&argc, &argv, NULL, "DEFAULT");
if (getuid () != 0) {
g_print ("Missing permission: must run as root\n");
return EXIT_FAILURE;
}
loop = g_main_loop_new (NULL, FALSE);
nm_linux_platform_setup ();
if (argv[1]) {
ifname = argv[1];
platform: add self argument to platform functions Most nm_platform_*() functions operate on the platform singleton nm_platform_get(). That made sense because the NMPlatform instance was mainly to hook fake platform for testing. While the implicit argument saved some typing, I think explicit is better. Especially, because NMPlatform could become a more usable object then just a hook for testing. With this change, NMPlatform instances can be used individually, not only as a singleton instance. Before this change, the constructor of NMLinuxPlatform could not call any nm_platform_*() functions because the singleton was not yet initialized. We could only instantiate an incomplete instance, register it via nm_platform_setup(), and then complete initialization via singleton->setup(). With this change, we can create and fully initialize NMPlatform instances before/without setting them up them as singleton. Also, currently there is no clear distinction between functions that operate on the NMPlatform instance, and functions that can be used stand-alone (e.g. nm_platform_ip4_address_to_string()). The latter can not be mocked for testing. With this change, the distinction becomes obvious. That is also useful because it becomes clearer which functions make use of the platform cache and which not. Inside nm-linux-platform.c, continue the pattern that the self instance is named @platform. That makes sense because its type is NMPlatform, and not NMLinuxPlatform what we would expect from a paramter named @self. This is a major diff that causes some pain when rebasing. Try to rebase to the parent commit of this commit as a first step. Then rebase on top of this commit using merge-strategy "ours".
2015-04-18 12:36:09 +02:00
ifindex = nm_platform_link_get_ifindex (NM_PLATFORM_GET, ifname);
} else {
g_print ("Missing command line argument \"interface-name\"\n");
return EXIT_FAILURE;
2013-05-31 15:49:07 +02:00
}
rdisc = nm_lndp_rdisc_new (ifindex, ifname);
if (!rdisc) {
g_print ("Failed to create NMRDisc instance\n");
return EXIT_FAILURE;
}
nm_rdisc_start (rdisc);
g_main_loop_run (loop);
g_clear_object (&rdisc);
return EXIT_SUCCESS;
}