fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-17 14:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src/core/devices/nm-device-logging.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

48 lines
3 KiB
C
Raw Normal View History

all: update deprecated SPDX license identifiers These SPDX license identifiers are deprecated ([1]). Update them. [1] https://spdx.org/licenses/ sed \ -e '1 s%^/\* SPDX-License-Identifier: \(GPL-2.0\|LGPL-2.1\)+ \*/$%/* SPDX-License-Identifier: \1-or-later */%' \ -e '1,2 s%^\(--\|#\|//\) SPDX-License-Identifier: \(GPL-2.0\|LGPL-2.1\)+$%\1 SPDX-License-Identifier: \2-or-later%' \ -i \ $(git grep -l SPDX-License-Identifier -- \ ':(exclude)shared/c-*/' \ ':(exclude)shared/n-*/' \ ':(exclude)shared/systemd/src' \ ':(exclude)src/systemd/src')
2020-12-23 22:21:36 +01:00
/* SPDX-License-Identifier: GPL-2.0-or-later */
all: manually drop code comments with file description
2019-09-25 13:13:40 +02:00
/*
logging: extract logging macros for devices to nm-device-logging.h Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-08-02 14:52:49 +02:00
* Copyright (C) 2014 Red Hat, Inc.
*/
all: fix up multiple-include-guard defines Previously, src/nm-ip4-config.h, libnm/nm-ip4-config.h, and libnm-glib/nm-ip4-config.h all used "NM_IP4_CONFIG_H" as an include guard, which meant that nm-test-utils.h could not tell which of them was being included (and so, eg, if you tried to include nm-ip4-config.h in a libnm test, it would fail to compile because nm-test-utils.h was referring to symbols in src/nm-ip4-config.h). Fix this by changing the include guards in the non-API-stable parts of the tree: - libnm-glib/nm-ip4-config.h remains NM_IP4_CONFIG_H - libnm/nm-ip4-config.h now uses __NM_IP4_CONFIG_H__ - src/nm-ip4-config.h now uses __NETWORKMANAGER_IP4_CONFIG_H__ And likewise for all other headers. The two non-"nm"-prefixed headers, libnm/NetworkManager.h and src/NetworkManagerUtils.h are now __NETWORKMANAGER_H__ and __NETWORKMANAGER_UTILS_H__ respectively, which, while not entirely consistent with the general scheme, do still mostly make sense in isolation.
2014-08-13 14:10:11 -04:00
#ifndef __NETWORKMANAGER_DEVICE_LOGGING_H__
#define __NETWORKMANAGER_DEVICE_LOGGING_H__
logging: extract logging macros for devices to nm-device-logging.h Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-08-02 14:52:49 +02:00
#include "nm-device.h"
device: improve "nm-device-logging.h" to support a self pointer of NMDevice type "nm-device-logging.h" defines logging macros for a NMDevice instance. It also expects a "self" variable in the call environment, and that variable had to be in the type of NMDevice or the NMDevice subclass. Extend the macro foo, so that @self can be either a NMDevice* pointer or a NMDevice$SUBTYPE. Of course, that would have always been possible, if we would simply cast to "(NMDevice *)" where we need it. The trick is that the macro only works if @self is one of the two expected types, and not some arbitrary unrelated type.
2020-11-06 18:22:11 +01:00
#if !_NM_CC_SUPPORT_GENERIC
clang-format: use "IndentPPDirectives:None" instead of "BeforeHash" Subjectively, I think this looks better.
2021-07-09 08:48:48 +02:00
#define _NM_DEVICE_CAST(self) ((NMDevice *) (self))
device: improve "nm-device-logging.h" to support a self pointer of NMDevice type "nm-device-logging.h" defines logging macros for a NMDevice instance. It also expects a "self" variable in the call environment, and that variable had to be in the type of NMDevice or the NMDevice subclass. Extend the macro foo, so that @self can be either a NMDevice* pointer or a NMDevice$SUBTYPE. Of course, that would have always been possible, if we would simply cast to "(NMDevice *)" where we need it. The trick is that the macro only works if @self is one of the two expected types, and not some arbitrary unrelated type.
2020-11-06 18:22:11 +01:00
#elif !defined(_NMLOG_DEVICE_TYPE)
all: avoid "-Wunreachable-code-generic-assoc" warning with _Generic() Clang 15 ([1], [2]) added Added the -Wunreachable-code-generic-assoc diagnostic flag (grouped under the -Wunreachable-code flag) which is enabled by default and warns the user about _Generic selection associations which are unreachable because the type specified is an array type or a qualified type. This causes compiler warnings with various uses of _Generic(): ../src/libnm-glib-aux/nm-shared-utils.h:2489:12: error: due to lvalue conversion of the controlling expression, association of type 'const char *const *const' will never be selected becaus e it is qualified [-Werror,-Wunreachable-code-generic-assoc] return nm_strv_find_first((const char *const *) strv->pdata, strv->len, str); ^ ../src/libnm-glib-aux/nm-shared-utils.h:475:25: note: expanded from macro 'nm_strv_find_first' _nm_strv_find_first(NM_CAST_STRV_CC(list), (len), (needle)) ^ ../src/libnm-glib-aux/nm-macros-internal.h:397:22: note: expanded from macro 'NM_CAST_STRV_CC' const char *const*const: (const char *const*) (value), \ ^ Clang is correct. [1] https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics [2] https://reviews.llvm.org/D125259
2022-10-11 11:07:25 +02:00
#define _NM_DEVICE_CAST(self) _Generic((self), NMDevice *: ((NMDevice *) (self)))
device: improve "nm-device-logging.h" to support a self pointer of NMDevice type "nm-device-logging.h" defines logging macros for a NMDevice instance. It also expects a "self" variable in the call environment, and that variable had to be in the type of NMDevice or the NMDevice subclass. Extend the macro foo, so that @self can be either a NMDevice* pointer or a NMDevice$SUBTYPE. Of course, that would have always been possible, if we would simply cast to "(NMDevice *)" where we need it. The trick is that the macro only works if @self is one of the two expected types, and not some arbitrary unrelated type.
2020-11-06 18:22:11 +01:00
#else
all: avoid "-Wunreachable-code-generic-assoc" warning with _Generic() Clang 15 ([1], [2]) added Added the -Wunreachable-code-generic-assoc diagnostic flag (grouped under the -Wunreachable-code flag) which is enabled by default and warns the user about _Generic selection associations which are unreachable because the type specified is an array type or a qualified type. This causes compiler warnings with various uses of _Generic(): ../src/libnm-glib-aux/nm-shared-utils.h:2489:12: error: due to lvalue conversion of the controlling expression, association of type 'const char *const *const' will never be selected becaus e it is qualified [-Werror,-Wunreachable-code-generic-assoc] return nm_strv_find_first((const char *const *) strv->pdata, strv->len, str); ^ ../src/libnm-glib-aux/nm-shared-utils.h:475:25: note: expanded from macro 'nm_strv_find_first' _nm_strv_find_first(NM_CAST_STRV_CC(list), (len), (needle)) ^ ../src/libnm-glib-aux/nm-macros-internal.h:397:22: note: expanded from macro 'NM_CAST_STRV_CC' const char *const*const: (const char *const*) (value), \ ^ Clang is correct. [1] https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics [2] https://reviews.llvm.org/D125259
2022-10-11 11:07:25 +02:00
#define _NM_DEVICE_CAST(self) \
_Generic((self), _NMLOG_DEVICE_TYPE *: ((NMDevice *) (self)), NMDevice *: ((NMDevice *) (self)))
device: improve "nm-device-logging.h" to support a self pointer of NMDevice type "nm-device-logging.h" defines logging macros for a NMDevice instance. It also expects a "self" variable in the call environment, and that variable had to be in the type of NMDevice or the NMDevice subclass. Extend the macro foo, so that @self can be either a NMDevice* pointer or a NMDevice$SUBTYPE. Of course, that would have always been possible, if we would simply cast to "(NMDevice *)" where we need it. The trick is that the macro only works if @self is one of the two expected types, and not some arbitrary unrelated type.
2020-11-06 18:22:11 +01:00
#endif
logging: extract logging macros for devices to nm-device-logging.h Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-08-02 14:52:49 +02:00
logging: declare default logging macros in "nm-logging.h" The logging macros _LOGD(), etc. are specific to each file as they format the message according to their context. Still, they were cumbersome to define and their implementation was repeated over and over (slightly different at times). Move the declaration of these macros to "nm-logging.h". The source file now only needs to define _NMLOG(), and either _NMLOG_ENABLED() or _NMLOG_DOMAIN. This reduces code duplication and encourages a common implementation and usage of these macros.
2015-08-20 00:07:14 +02:00
#undef _NMLOG_ENABLED
#define _NMLOG_ENABLED(level, domain) (nm_logging_enabled((level), (domain)))
core: log the device type when it can be ambiguous Use the nm_device_get_type_desc_for_log() helper function defined earlier to show the device type when it can be ambiguous. With this, the log becomes a bit more explicative when there are OVS devices involved: <info> device (ovs-br)[Open vSwitch Bridge]: state change: ip-config -> ip-check (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br)[Open vSwitch Port]: state change: ip-check -> secondaries (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br)[Open vSwitch Port]: state change: secondaries -> activated (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br)[Open vSwitch Port]: Activation: successful, device activated. <info> device (ovs-br)[Open vSwitch Bridge]: state change: ip-check -> secondaries (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br)[Open vSwitch Bridge]: state change: secondaries -> activated (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br)[Open vSwitch Bridge]: Activation: successful, device activated. <info> device (ovs-br)[Open vSwitch Interface]: state change: unmanaged -> unavailable (reason 'managed', sys-iface-state: 'external') <info> device (ovs-br)[Open vSwitch Interface]: state change: unavailable -> disconnected (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br)[Open vSwitch Interface]: Activation: starting connection 'ovs-interface+' (d3d429b1-3193-4462-a17a-034255c43776) instead of: <info> device (ovs-br): state change: ip-config -> ip-check (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br): state change: ip-check -> secondaries (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br): state change: secondaries -> activated (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br): Activation: successful, device activated. <info> device (ovs-br): state change: ip-check -> secondaries (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br): state change: secondaries -> activated (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br): Activation: successful, device activated. <info> device (ovs-br): state change: unmanaged -> unavailable (reason 'managed', sys-iface-state: 'external') <info> device (ovs-br): state change: unavailable -> disconnected (reason 'none', sys-iface-state: 'managed') <info> device (ovs-br): Activation: starting connection 'ovs-interface+' (d3d429b1-3193-4462-a17a-034255c43776)
2023-05-22 17:56:22 +02:00
#define _NMLOG(level, domain, ...) \
G_STMT_START \
{ \
const NMLogLevel _level = (level); \
const NMLogDomain _domain = (domain); \
\
if (nm_logging_enabled(_level, _domain)) { \
typeof(*self) *const _self = (self); \
const char *const _ifname = _nm_device_get_iface(_NM_DEVICE_CAST(_self)); \
const char *_type = nm_device_get_type_desc_for_log(_NM_DEVICE_CAST(_self)); \
\
nm_log_obj(_level, \
_domain, \
_ifname, \
NULL, \
_self, \
"device", \
"%s%s%s%s%s%s: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
NM_PRINT_FMT_QUOTED(_ifname, "(", _ifname, ")", "[null]"), \
NM_PRINT_FMT_QUOTED(_type, "[", _type, "]", "") \
_NM_UTILS_MACRO_REST(__VA_ARGS__)); \
} \
} \
device: rework device's _NMLOG() logging macro - if the interface-name is NULL, print [null], to distinguish it from (ifname). - evaluate the ifname only once.
2017-06-07 12:18:21 +02:00
G_STMT_END
logging: extract logging macros for devices to nm-device-logging.h Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-08-02 14:52:49 +02:00
all: fix up multiple-include-guard defines Previously, src/nm-ip4-config.h, libnm/nm-ip4-config.h, and libnm-glib/nm-ip4-config.h all used "NM_IP4_CONFIG_H" as an include guard, which meant that nm-test-utils.h could not tell which of them was being included (and so, eg, if you tried to include nm-ip4-config.h in a libnm test, it would fail to compile because nm-test-utils.h was referring to symbols in src/nm-ip4-config.h). Fix this by changing the include guards in the non-API-stable parts of the tree: - libnm-glib/nm-ip4-config.h remains NM_IP4_CONFIG_H - libnm/nm-ip4-config.h now uses __NM_IP4_CONFIG_H__ - src/nm-ip4-config.h now uses __NETWORKMANAGER_IP4_CONFIG_H__ And likewise for all other headers. The two non-"nm"-prefixed headers, libnm/NetworkManager.h and src/NetworkManagerUtils.h are now __NETWORKMANAGER_H__ and __NETWORKMANAGER_UTILS_H__ respectively, which, while not entirely consistent with the general scheme, do still mostly make sense in isolation.
2014-08-13 14:10:11 -04:00
#endif /* __NETWORKMANAGER_DEVICE_LOGGING_H__ */
Reference in a new issue Copy permalink