NetworkManager/src/devices/nm-device-ethernet-utils.h

/* SPDX-License-Identifier: GPL-2.0+ */
/*
 * Copyright (C) 2011 Red Hat, Inc.
 */

#ifndef __NETWORKMANAGER_DEVICE_ETHERNET_UTILS_H__
#define __NETWORKMANAGER_DEVICE_ETHERNET_UTILS_H__

char *nm_device_ethernet_utils_get_default_wired_name(GHashTable *existing_ids);

#endif /* NETWORKMANAGER_DEVICE_ETHERNET_UTILS_H */
all: unify comment style for SPDX-License-Identifier tag Our coding style recommends C style comments (/* /) instead of C++ (//). Also, systemd (which we partly fork) uses C style comments for the SPDX-License-Identifier. Unify the style. $ sed -i '1 s#// SPDX-License-Identifier: \([^ ]\+\)$#/ SPDX-License-Identifier: \1 /#' -- $(git ls-files -- '.[hc]' '*.[hc]pp') 2020-09-29 16:42:22 +02:00			`/* SPDX-License-Identifier: GPL-2.0+ */`
all: manually drop code comments with file description 2019-09-25 13:13:40 +02:00			`/*`
all: unify format of our Copyright source code comments ```bash readarray -d '' FILES < <( git ls-files -z \ ':(exclude)po' \ ':(exclude)shared/c-rbtree' \ ':(exclude)shared/c-list' \ ':(exclude)shared/c-siphash' \ ':(exclude)shared/c-stdaux' \ ':(exclude)shared/n-acd' \ ':(exclude)shared/n-dhcp4' \ ':(exclude)src/systemd/src' \ ':(exclude)shared/systemd/src' \ ':(exclude)m4' \ ':(exclude)COPYING' ) sed \ -e 's/^\(--\\|#\\| \\) \(([cC]) \)\?Copyright \+\(\(([cC])\) \+\)\?\(\(20\\|19\)[0-9][0-9]\) [-–] \(\(20\\|19\)[0-9][0-9]\) \+\([^ ].\)$/\1 C1pyright#\5 - \7#\9/' \ -e 's/^\(--\\|#\\| \\) \(([cC]) \)\?Copyright \+\(\(([cC])\) \+\)\?\(\(20\\|19\)[0-9][0-9]\) [,] \(\(20\\|19\)[0-9][0-9]\) \+\([^ ].\)$/\1 C2pyright#\5, \7#\9/' \ -e 's/^\(--\\|#\\| \\) \(([cC]) \)\?Copyright \+\(\(([cC])\) \+\)\?\(\(20\\|19\)[0-9][0-9]\) \+\([^ ].\)$/\1 C3pyright#\5#\7/' \ -e 's/^Copyright \(\(20\\|19\)[0-9][0-9]\) \+\([^ ].\)$/C4pyright#\1#\3/' \ -i \ "${FILES[@]}" echo ">>> untouched Copyright lines" git grep Copyright "${FILES[@]}" echo ">>> Copyright lines with unusual extra" git grep '\<C[0-9]pyright#' "${FILES[@]}" \| grep -i reserved sed \ -e 's/\<C[0-9]pyright#\([^#]\)#\(.\)$/Copyright (C) \1 \2/' \ -i \ "${FILES[@]}" ``` https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/298 2019-10-01 09:20:35 +02:00			`* Copyright (C) 2011 Red Hat, Inc.`
settings: fix getting default wired connection name with no connections Due to an error in the loop logic, if there were no connections yet (like a fresh install or a livecd or whatever) no default name would be returned and thus ethernet devices wouldn't come up automatically. Fix that loop error and add testcases for it. 2011-03-30 12:02:50 -05:00			`*/`

settings: create default wired connection from NMDeviceEthernet Instead of creating it in NMSettings, where we must use NM_IS_DEVICE_ETHERNET() (not NM_DEVICE_TYPE_ETHERNET because various generic devices masquerade as NM_DEVICE_TYPE_ETHERNET too), push knowledge of which device types create default wired connections into the device types themselves. This solves a problem with testcases where libNetworkManager.a (which testcases link to) requires the symbol nm_type_device_ethernet(). 2014-09-08 16:11:51 -05:00			`#ifndef __NETWORKMANAGER_DEVICE_ETHERNET_UTILS_H__`
			`#define __NETWORKMANAGER_DEVICE_ETHERNET_UTILS_H__`
settings: fix getting default wired connection name with no connections Due to an error in the loop logic, if there were no connections yet (like a fresh install or a livecd or whatever) no default name would be returned and thus ethernet devices wouldn't come up automatically. Fix that loop error and add testcases for it. 2011-03-30 12:02:50 -05:00
settings: use delegation instead of inheritance for NMSettingsConnection and NMConnection NMConnection is an interface, which is implemented by the types NMSimpleConnection (libnm-core), NMSettingsConnection (src) and NMRemoteConnection (libnm). NMSettingsConnection does a lot of things already: 1) it "is-a" NMDBusObject and exports the API of a connection profile on D-Bus 2) it interacts with NMSettings and contains functionality for tracking the profiles. 3) it is the base-class of types like NMSKeyfileConnection and NMIfcfgConnection. These handle how the profile is persisted on disk. 4) it implements NMConnection interface, to itself track the settings of the profile. 3) and 4) would be better implemented via delegation than inheritance. Address 4) and don't let NMSettingsConnection implemente the NMConnection interface. Instead, a settings-connection references now a NMSimpleConnection instance, to which it delegates for keeping the actual profiles. Advantages: - by delegating, there is a clearer separation of what NMSettingsConnection does. For example, in C we often required casts from NMSettingsConnection to NMConnection. NMConnection is a very trivial object with very little logic. When we have a NMConnection instance at hand, it's good to know that it is only that simple instead of also being an entire NMSettingsConnection instance. The main purpose of this patch is to simplify the code by separating the NMConnection from the NMSettingsConnection. We should generally be aware whether we handle a NMSettingsConnection or a trivial NMConnection instance. Now, because NMSettingsConnection no longer "is-a" NMConnection, this distinction is apparent. - NMConnection is implemented as an interface and we create NMSimpleConnection instances whenever we need a real instance. In GLib, interfaces have a performance overhead, that we needlessly pay all the time. With this change, we no longer require NMConnection to be an interface. Thus, in the future we could compile a version of libnm-core for the daemon, where NMConnection is not an interface but a GObject implementation akin to NMSimpleConnection. - In the previous implementation, we cannot treat NMConnection immutable and copy-on-write. For example, when NMDevice needs a snapshot of the activated profile as applied-connection, all it can do is clone the entire NMSettingsConnection as a NMSimpleConnection. Likewise, when we get a NMConnection instance and want to keep a reference to it, we cannot do that, because we never know who also references and modifies the instance. By separating NMSettingsConnection we could in the future have NMConnection immutable and copy-on-write, to avoid all unnecessary clones. 2018-08-11 11:08:17 +02:00			`char nm_device_ethernet_utils_get_default_wired_name(GHashTable existing_ids);`
settings: fix getting default wired connection name with no connections Due to an error in the loop logic, if there were no connections yet (like a fresh install or a livecd or whatever) no default name would be returned and thus ethernet devices wouldn't come up automatically. Fix that loop error and add testcases for it. 2011-03-30 12:02:50 -05:00
settings: create default wired connection from NMDeviceEthernet Instead of creating it in NMSettings, where we must use NM_IS_DEVICE_ETHERNET() (not NM_DEVICE_TYPE_ETHERNET because various generic devices masquerade as NM_DEVICE_TYPE_ETHERNET too), push knowledge of which device types create default wired connections into the device types themselves. This solves a problem with testcases where libNetworkManager.a (which testcases link to) requires the symbol nm_type_device_ethernet(). 2014-09-08 16:11:51 -05:00			`#endif /* NETWORKMANAGER_DEVICE_ETHERNET_UTILS_H */`